Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds/clusterresolver: set ClusterName for DNS child #5119

Merged
merged 2 commits into from
Jan 12, 2022
Merged

xds/clusterresolver: set ClusterName for DNS child #5119

merged 2 commits into from
Jan 12, 2022

Conversation

menghanl
Copy link
Contributor

@menghanl menghanl commented Jan 11, 2022 •
edited by easwars
Loading

DNS child policies also need the cluster name, because the cluster name are attached to the addresses, which may affect creds handshake.

RELEASE NOTES:

  • xds/clusterresolver: fix that DNS child does wrong creds handshake because ClusterName isn't set correctly.

@menghanl menghanl requested a review from easwars January 11, 2022 19:32
@menghanl menghanl added this to the 1.44 Release milestone Jan 11, 2022
@zasweq zasweq modified the milestones: 1.44 Release, 1.45 Release Jan 11, 2022
@easwars easwars assigned menghanl and unassigned easwars Jan 11, 2022
@menghanl menghanl merged commit b49c0c9 into grpc:master Jan 12, 2022
@menghanl menghanl deleted the cluster_resolver_dns_cluster branch January 12, 2022 19:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@easwars easwars easwars approved these changes

Assignees

@menghanl menghanl

Labels
Type: Bug
Projects
None yet
Milestone
1.45 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@menghanl @easwars @zasweq