protobuf: update github.com/golang/protobuf to google.golang.org/protobuf #5319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe I should break this PR into several PRs, I'll start with #5320 |
gunturaf
changed the title
menghanl
reviewed
Apr 28, 2022
| spb "google.golang.org/genproto/googleapis/rpc/status" | ||
| "google.golang.org/grpc/codes" | ||
| "google.golang.org/protobuf/proto" |
There was a problem hiding this comment.
This has the same problem as discussed in #4330
It changes the API for WithDetails (#4330 (comment))
|
Closing this in favor of separate PRs as mentioned in #5319 (comment). Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #5316
github.com/golang/protobufreferences togoogle.golang.org/protobufexcept for the packagereflection/grpc_testing_not_regeneratetest/toolspackage.make vetis currently failing due to the fact that there's a cross-import fromgoogle.golang.org/grpctogoogle.golang.org/grpc/reflection/grpc_testing_not_regenerateand vice versa. This issue can be easily resolved if I allowed to replace thegithub.com/golang/protobufreference inside thegrpc_testing_not_regeneratepackage and do not use the sub-module approach. Any advice is welcomed!