xds/ringhash: update connectivity state aggregation, and make sure at least one SubConn is connecting in TF #5338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ggregation, and make sure on SubConn is connecting in TF
menghanl
changed the title
dfawley
reviewed
May 17, 2022
| @@ -147,8 +156,10 @@ func (sc *subConn) effectiveState() connectivity.State { | |||
| // it's Connect() will be triggered. If the SubConn state is already Idle, it | |||
| // will just call Connect(). | |||
| func (sc *subConn) queueConnect() { | |||
| fmt.Printf(" ===== queue connect for %v\n", sc) | |||
There was a problem hiding this comment.
Delete (there are at least a few of these in here)
| @@ -417,6 +463,12 @@ func (cse *connectivityStateEvaluator) recordTransition(oldState, newState conne | |||
| updateVal := 2*uint64(idx) - 1 // -1 for oldState and +1 for new. | |||
| cse.nums[state] += updateVal | |||
| } | |||
| if oldState == connectivity.Shutdown { | |||
There was a problem hiding this comment.
Can you ever transition from shutdown?
There was a problem hiding this comment.
When a new SubConn is created, we record a shutdown->idle transition.
(And I believe we do the same in roundrobin)
There was a problem hiding this comment.
Ah yes, that makes sense thanks.
dfawley
approved these changes
May 17, 2022
| @@ -417,6 +463,12 @@ func (cse *connectivityStateEvaluator) recordTransition(oldState, newState conne | |||
| updateVal := 2*uint64(idx) - 1 // -1 for oldState and +1 for new. | |||
| cse.nums[state] += updateVal | |||
| } | |||
| if oldState == connectivity.Shutdown { | |||
There was a problem hiding this comment.
Ah yes, that makes sense thanks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grpc/proposal#296
RELEASE NOTES: N/A