Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: fix binary logging bug which logs a server header on a trailers only response #5763

Merged
merged 1 commit into from Nov 2, 2022

Conversation

zasweq
Copy link
Contributor

@zasweq zasweq commented Nov 2, 2022

Fixes #5706. Uses an invariant of the system, s.noHeaders, and propagates that signal to the client stream to gate the Server Header logging call. No explicit test, but have tests that test this at very specific granularity and you can see deleting the Server Header expectation for the want makes the tests pass.

RELEASE NOTES:

  • client: fix binary logging bug which logs a server header on a trailers-only response

@zasweq zasweq added this to the 1.51 Release milestone Nov 2, 2022
@zasweq zasweq requested a review from dfawley Nov 2, 2022
dfawley
dfawley approved these changes Nov 2, 2022
@dfawley dfawley assigned zasweq and unassigned dfawley Nov 2, 2022
@dfawley dfawley changed the title Fix binary logging bug which logs a server header on a trailers only response client: fix binary logging bug which logs a server header on a trailers only response Nov 2, 2022
@zasweq zasweq merged commit 36d14db into grpc:master Nov 2, 2022
11 checks passed
jronak pushed a commit to jronak/grpc-go that referenced this pull request Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binary logging: Logging Server Header on trailers only response
2 participants