resolver: document handling UpdateState errors by resolvers #6002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
added
Type: Documentation
|
@dfawley thanks for the feedback, I adapted it to your suggestions, please have a look again |
Extend the Godoc for resolver.ClientConn.UpdateState with a description of how resolvers should handle returned errors. The description is based on the explanation of dfawley in grpc#5048
dfawley
approved these changes
Feb 8, 2023
There was a problem hiding this comment.
Thank you! For future reference, please do not perform force-pushes when updating PR comments, as this messes up github review comments and loses the history of the PR as it changed over time. This one was small enough that it doesn't matter, but it's a good general practice to follow.
Thanks for the change!
|
@zasweq please double-check and approve so we can merge this, thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the Godoc for resolver.ClientConn.UpdateState with a description of how resolvers should handle returned errors.
The description is based on the explanation of dfawley in #5048
RELEASE NOTES: