Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: add support for pickfirst address shuffling from gRFC A62 #6311

Merged
merged 3 commits into from
May 24, 2023
Merged

client: add support for pickfirst address shuffling from gRFC A62 #6311

merged 3 commits into from
May 24, 2023

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented May 23, 2023

RELEASE NOTES:

  • client: add support for pickfirst address shuffling from gRFC A62

@dfawley dfawley added the Type: Feature New features or improvements in behavior label May 23, 2023
@dfawley dfawley added this to the 1.56 Release milestone May 23, 2023
@dfawley dfawley requested review from easwars and arvindbr8 May 23, 2023 22:12
arvindbr8
arvindbr8 approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@arvindbr8 arvindbr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚢

arvindbr8
arvindbr8 requested changes May 24, 2023
View reviewed changes
Copy link
Member

@arvindbr8 arvindbr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait. Tests dont agree with me. Seems like a few more are failing. Might wanna take a look.

@arvindbr8 arvindbr8 assigned dfawley and unassigned arvindbr8 May 24, 2023
@dfawley
Copy link
Member Author

dfawley commented May 24, 2023

Test fixed. Also as a bonus I added an additional log that, without, we never see the returned error from the lb policy's UpdateCCS method.

@dfawley dfawley assigned arvindbr8 and unassigned dfawley May 24, 2023
@arvindbr8 arvindbr8 assigned dfawley and unassigned arvindbr8 May 24, 2023
@dfawley dfawley merged commit 59134c3 into grpc:master May 24, 2023
1 check passed
@dfawley dfawley deleted the pf_random branch May 24, 2023 17:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arvindbr8 arvindbr8 arvindbr8 approved these changes

@easwars easwars Awaiting requested review from easwars

Assignees

@dfawley dfawley

Labels
Type: Feature New features or improvements in behavior
Projects
None yet
Milestone
1.56 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@dfawley @arvindbr8