Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/envconfig: Set Custom LB Env Var to true by default #6317

Merged
merged 3 commits into from May 25, 2023

Conversation

zasweq
Copy link
Contributor

@zasweq zasweq commented May 25, 2023

This PR sets the Custom LB Env Var to true by default. This functionality has been tested in interop, and is stable.

RELEASE NOTES:

  • xds: Enable support for load_balancing_policy field, including Custom LB specification by default (see gRFC A52 for details)

@zasweq zasweq requested a review from dfawley May 25, 2023 22:20
@zasweq zasweq added this to the 1.56 Release milestone May 25, 2023
@@ -89,7 +89,7 @@ var (
// C2PResolverTestOnlyTrafficDirectorURI is the TD URI for testing.
C2PResolverTestOnlyTrafficDirectorURI = os.Getenv("GRPC_TEST_ONLY_GOOGLE_C2P_RESOLVER_TRAFFIC_DIRECTOR_URI")
// XDSCustomLBPolicy indicates whether Custom LB Policies are enabled, which
// can be enabled by setting the environment variable
// can be disabled by setting the environment variable
// "GRPC_EXPERIMENTAL_XDS_CUSTOM_LB_CONFIG" to "true".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to "false"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Comment on lines 94 to 99
oldCustomLBSupport := envconfig.XDSCustomLBPolicy
envconfig.XDSCustomLBPolicy = true
defer func() {
envconfig.XDSCustomLBPolicy = oldCustomLBSupport
}()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably would be best to leave these in there until the env var is removed. Otherwise the tests will fail if you disable it in your environment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted these (by git checkout master ./) lol

@dfawley dfawley assigned zasweq and unassigned dfawley May 25, 2023
@zasweq zasweq merged commit 9b9b364 into grpc:master May 25, 2023
11 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants