Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: encode the authority by default #6428

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

anicr7
Copy link
Contributor

@anicr7 anicr7 commented Jun 30, 2023

Currently the endpoint is returned as the authority unless it can be determined by the scheme or from the dial or credentials. In case the endpoint has multiple slashes, this can be invalid. To handle this use case encode the authority by default.

In the future this can be subsumed by adding per resolver builder method that can provide a more sophisticated logic for determining authority.

@dfawley

PS: This is a rollforward of #6318 with slightly different logic to handle authority specific delims rather than piggy backing on the path escape.

RELEASE NOTES:

  • client: percent-encode the default authority for the channel

@anicr7 anicr7 changed the title Encode the authority by default client: encode the authority by default Jun 30, 2023
@anicr7 anicr7 marked this pull request as ready for review June 30, 2023 23:00
@dfawley dfawley self-requested a review July 5, 2023 17:15
@dfawley dfawley self-assigned this Jul 5, 2023
@dfawley dfawley added this to the 1.57 Release milestone Jul 10, 2023
@dfawley dfawley added the Type: Behavior Change Behavior changes not categorized as bugs label Jul 10, 2023
@dfawley dfawley merged commit fc0aa46 into grpc:master Jul 10, 2023
1 check passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Behavior Change Behavior changes not categorized as bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants