grpc: perform a blocking close of the balancer in ccb #6497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you clarify this? Is this the new policy or the old policy? |
dfawley
approved these changes
Aug 3, 2023
Comment on lines
408
to
+414
| // Verify that the ClientConn moves to READY. | ||
| ctx, cancel := context.WithTimeout(context.Background(), defaultTestTimeout) | ||
| defer cancel() | ||
| awaitState(ctx, t, cc, connectivity.Ready) | ||
| client := testgrpc.NewTestServiceClient(cc) | ||
| if _, err := client.EmptyCall(ctx, &testpb.Empty{}); err != nil { | ||
| t.Errorf("EmptyCall RPC failed: %v", err) | ||
| } |
There was a problem hiding this comment.
Why not just delete this entirely? We're going to perform 20 RPCs after this anyway.
There was a problem hiding this comment.
This acts as a sanity check to ensure that the channel is READY and can make RPCs before we get to our actual test. So, if for some reason, the channel doesn't become READY, then we will fail here and will have a better signal instead of failing down below wherein we might initially think the failure is because of a bad interaction between idle timeout firing and a new RPC being made.
It is the old policy. Updated the PR description. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issue:
READYand things are goodIDLEIDLEand a new LB policy is createdREADYTRANSIENT_FAILUREThis whole scenario can be prevented if the old policy was shutdown inline when the channel entered
IDLE.This PR also includes a minor fix to one of the tests to prevent a race where the test is waiting for the channel become
READY. But it could so happen that the channel becameREADYand in fact becameIDLEbefore the test started the check. Instead of relying on the connectivity state, the test now performs an RPC to ensure that the channel is in factREADY.RELEASE NOTES:
TRANSIENT_FAILUREwhen actually moving toIDLE