Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: remove dependency of github.com/golang/protobuf from main module #7122

Merged
merged 3 commits into from
Apr 11, 2024
Merged

deps: remove dependency of github.com/golang/protobuf from main module #7122

merged 3 commits into from
Apr 11, 2024

Conversation

arvindbr8
Copy link
Member

@arvindbr8 arvindbr8 commented Apr 11, 2024 •
edited
Loading

Should be the last piece which fixes #5316 to nth degree. There is an indirect dependency on the package which can only be removed when our other dependencies remove the transitive dependency on github.com/golang/protobuf

RELEASE NOTES:

  • deps: remove dependency on github.com/golang/protobuf

dfawley
dfawley reviewed Apr 11, 2024
View reviewed changes
reflection/internal/internal.go Show resolved Hide resolved
reflection/internal/internal.go Show resolved Hide resolved
reflection/internal/internal.go Show resolved Hide resolved
arvindbr8
arvindbr8 commented Apr 11, 2024
View reviewed changes
Copy link
Member Author

@arvindbr8 arvindbr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. :)

reflection/internal/internal.go Show resolved Hide resolved
reflection/internal/internal.go Show resolved Hide resolved
reflection/internal/internal.go Show resolved Hide resolved
@arvindbr8 arvindbr8 requested a review from dfawley April 11, 2024 21:04
@arvindbr8 arvindbr8 added the Type: Dependencies Updating/adding/removing dependencies label Apr 11, 2024
@arvindbr8 arvindbr8 added this to the 1.64 Release milestone Apr 11, 2024
@arvindbr8 arvindbr8 linked an issue Apr 11, 2024 that may be closed by this pull request
Update proto package imports to google.golang.org/protobuf/proto #5316
Closed
@arvindbr8 arvindbr8 merged commit a4afd4d into grpc:master Apr 11, 2024
11 of 12 checks passed
@arvindbr8 arvindbr8 deleted the dep_github_protobuf branch April 11, 2024 21:35
@ash2k
Copy link
Contributor

ash2k commented Apr 11, 2024

Happy to see this! Thank you!

@Clement-Jean
Copy link
Contributor

Good job @arvindbr8 !

@arvindbr8 arvindbr8 mentioned this pull request Apr 17, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@dfawley dfawley

Labels
Type: Dependencies Updating/adding/removing dependencies
Projects
None yet
Milestone
1.64 Release
Development

Successfully merging this pull request may close these issues.

Update proto package imports to google.golang.org/protobuf/proto
4 participants
@arvindbr8 @ash2k @Clement-Jean @dfawley