client: Drop two calls to pretty.ToJSON and move code outside of lock
#7132
Conversation
There was a problem hiding this comment.
Could you please add a comment to addrConn's mu field that says something like "This is taken on the RPC path, so its usage should be minimized as much as possible. TODO: find a lock-free way to retrieve the transport and state from the addrConn without a lock"
| if limit > 5 { | ||
| limit = 5 | ||
| } | ||
| channelz.Infof(logger, ac.channelz, "addrConn: updateAddrs addrs (%d of %d): %v", limit, len(addrs), addrs[:limit]) |
There was a problem hiding this comment.
Can you show what this looks like, please? (Mainly I'm not sure: does %v on a slice call String() for each member?)
There was a problem hiding this comment.
Looks something like this:
addrConn: updateAddrs addrs (3 of 3): [{Addr: "127.0.0.1:35771", ServerName: "", } {Addr: "127.0.0.1:41729", ServerName: "", } {Addr: "127.0.0.1:36587", ServerName: "", }]
dfawley
added
the
Type: Performance
|
This may be significant enough to warrant a patch release. We should at least cherry-pick it so it will be in the next patch release, even if we don't want to do a release for only this. |
Done. |
|
PTAL |
| if limit > 5 { | ||
| limit = 5 | ||
| } | ||
| channelz.Infof(logger, ac.channelz, "addrConn: updateAddrs addrs (%d of %d): %v", limit, len(addrs), addrs[:limit]) |
clientconn.go
Outdated
| // TODO: Find a lock-free way to retrieve the transport and state from the | ||
| // addrConn without a lock. |
There was a problem hiding this comment.
Oops, "lock-free ... without a lock" - please remove one or the other. Thanks!
RELEASE NOTES: