-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xds/bootstrap: add testing support to generate config #7326
Conversation
a0d455b
to
6c9e214
Compare
@arvindbr8 : Unfortunately this has morphed into a nasty monster. Didn't realize the xDS management server was used by so many of our tests. Happy reviewing :p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly minor comments. Please let me know what you think
Sorry for making you open the can of worms here 😢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thank you very much for the review. |
Following up from #7299, this PR adds testing support to generate bootstrap configuration.
#a71-xds-fallback
RELEASE NOTES: none