add new include for v1.54.0 #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
reviewed
Apr 17, 2023
| @@ -6,7 +6,6 @@ install! 'cocoapods', :deterministic_uuids => false | |||
| GRPC_PODSPEC_ROOT = '../../../native' | |||
|
|
|||
| target 'gRPCSample' do | |||
| use_frameworks! | |||
There was a problem hiding this comment.
This could be problematic since almost all Apple apps now include Swift and thus require use_frameworks!
There was a problem hiding this comment.
It's no longer required any more since Swift supports static library a while back, and it doesn't work with new boring ssl either. This had been removed entirely from grpc/grpc repo.
There was a problem hiding this comment.
Swift supports static libraries, but still needs them packaged in frameworks with use_frameworks! :linkage => :static.
Separate from that, and sorry I don't have the full context here, SDKs often need to support clients choosing to link dynamically or statically.
HannahShiSFB
added a commit
to HannahShiSFB/grpc-ios
that referenced
this pull request
Apr 23, 2023
* add new include for v1.54.0 * remove use_frameworks! to work with new boring ssl
HannahShiSFB
added a commit
to HannahShiSFB/grpc-ios
that referenced
this pull request
Apr 24, 2023
* add new include for v1.54.0 * remove use_frameworks! to work with new boring ssl
HannahShiSFB
added a commit
that referenced
this pull request
Apr 24, 2023
* exclude src/objective-c/manual_tests/ from swift package * add new include for v1.54.0 (#190) * add new include for v1.54.0 * remove use_frameworks! to work with new boring ssl * add spm build for macos and tvos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will merge to main after release