-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adding AbstractStub.withCallOptions() #2143
Comments
Totally agree. I was surprised not to see the newStub function that would accept CallOptions |
I came looking for this functionality, too. I want to be able pass a |
As per this defect my understanding is newStub(channel, callOptions) to be introduced but in the codebase I can see this method is part of AbstractStub, so can you please provide what else to be needed. |
Looks like newStub(channel, callOptions) is added as part of #6458 |
You're talking about on StubFactory? That's an API for AbstractStub to call; there's no way for a user to call it. The newStub() mentioned is talking about the generated code. There's one of those methods per stub type. |
As per analysis we have made the https://github.com/grpc/grpc-java/pull/11734/files#:~:text=public%20final%20S%20withChannelAndCallOption,%7D changes in grpc-stub project with newly overloaded method, we stuck with validating the changes and need your directions to move forward. |
It would fully overwrite the current
CallOptions
. That could be considered "bad" because you don't know what you are overwriting, but it seems there are fine times to do so. Maybe it would be better to have a new generated methodnewStub(channel, callOptions)
instead?The text was updated successfully, but these errors were encountered: