Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding AbstractStub.withCallOptions() #2143

Open
ejona86 opened this issue Aug 8, 2016 · 2 comments
Open

Consider adding AbstractStub.withCallOptions() #2143

ejona86 opened this issue Aug 8, 2016 · 2 comments
Milestone

Comments

@ejona86
Copy link
Member

ejona86 commented Aug 8, 2016

It would fully overwrite the current CallOptions. That could be considered "bad" because you don't know what you are overwriting, but it seems there are fine times to do so. Maybe it would be better to have a new generated method newStub(channel, callOptions) instead?

@ejona86 ejona86 added this to the 1.1 milestone Aug 25, 2016
@IvanVas
Copy link

IvanVas commented Aug 26, 2016

Totally agree. I was surprised not to see the newStub function that would accept CallOptions

@ejona86 ejona86 modified the milestones: Next, 1.1 Jan 10, 2017
@marcomorain
Copy link

I came looking for this functionality, too. I want to be able pass a CallOptions to the generated newBlockingStub functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants