Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for StatusRuntimeException #4683

Closed
carl-mastrangelo opened this issue Jul 26, 2018 · 4 comments
Closed

Tracking issue for StatusRuntimeException #4683

carl-mastrangelo opened this issue Jul 26, 2018 · 4 comments
Assignees
@temawi
Labels
experimental API Issue tracks stabilizing an experimental API
Milestone
1.57

Comments

@carl-mastrangelo
Copy link
Contributor

No description provided.

@carl-mastrangelo
Copy link
Contributor Author

Notes from discussion:

  • Using Status.asException does the same thing, but not objectively better
  • Several users of both constructor and static factory
  • Considered making the ctor protected, so that the default construction is sans- trailers, but extenders can still call it.

Decision: Seems okay as is.

@carl-mastrangelo carl-mastrangelo mentioned this issue Jul 27, 2018
Merged
@ejona86 ejona86 added the experimental API Issue tracks stabilizing an experimental API label Jul 31, 2018
@ejona86 ejona86 added this to the Next milestone Jul 31, 2018
@ejona86
Copy link
Member

ejona86 commented Jan 9, 2020

API review:

  • We should stabilize Status.asException(Metadata). Yes, it is two ways of doing the same thing, but has been around a long time and doesn't hurt much.

@temawi temawi self-assigned this Sep 13, 2021
@temawi temawi mentioned this issue Sep 13, 2021
Merged
temawi added a commit that referenced this issue Sep 13, 2021
@temawi
api: Stabilize the Status.asException() call. (#8520)
876f56e 
Removes the ExperimentalApi annotation from this call.

Contributes to: #4683
@temawi temawi modified the milestones: Next, 1.42 Sep 14, 2022
@temawi temawi closed this as completed Sep 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2022
@larry-safran
Copy link
Contributor

larry-safran commented Feb 15, 2023 •
edited
Loading

Missed asRuntimeException(Metadata) and trailersFromThrowable()

@larry-safran larry-safran reopened this Feb 15, 2023
@temawi
Copy link
Contributor

temawi commented Jul 5, 2023

Fixed in #10322.

@temawi temawi closed this as completed Jul 5, 2023
@temawi temawi modified the milestones: 1.42, 1.57 Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@temawi temawi

Labels
experimental API Issue tracks stabilizing an experimental API
Projects
None yet
Milestone
1.57
Development

No branches or pull requests
4 participants
@ejona86 @carl-mastrangelo @temawi @larry-safran