Make builderFor* public on Providers, and update examples #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| server = NettyServerBuilder.forPort(port).addService(ServerInterceptors | ||
| .intercept(GreeterGrpc.bindService(new GreeterImpl()), new HeaderServerInterceptor())) | ||
| .build().start(); | ||
| server = ServerProvider.provider().builderForPort(port) |
There was a problem hiding this comment.
No, you should use ServerBuilder.forPort(port). ServerProvider is @Internal, so shouldn't be used directly.
There was a problem hiding this comment.
Derp, Done.
|
@carl-mastrangelo LGTM |
carl-mastrangelo
force-pushed
the
funrollLoops
branch
from
8be2cb6
to
fcb98d5
Compare
carl-mastrangelo
force-pushed
the
funrollLoops
branch
from
fcb98d5
to
41d93cf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1001
Not yet done for Clients since they depend on SSL specific behavior, not present yet.