Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add document on WRR configure example through service config #11344

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

YifeiZhuang
Copy link
Contributor

@YifeiZhuang YifeiZhuang commented Jun 27, 2024

Verified the configure through interop test, not exactly the same though:

$ JAVA_OPTS=-Djava.util.logging.config.file=logging.properties  ./run-test-client.sh --use_tls=false --service_config_json='{"loadBalancingConfig":[{"weighted_round_robin":{"enableOobLoadReport":true, "blackoutPeriod":"10s","oobReportingPeriod":"10s","weightExpirationPeriod":"100s","errorUtilizationPenalty":"0.12","weightUpdatePeriod":"3s"}}]}'
Running test empty_unary
Jun 27, 2024 3:21:57 PM io.grpc.xds.WeightedRoundRobinLoadBalancer <init>
FINE: weighted_round_robin LB created
Test completed.

@anicr7 verified through TD:

localityLbPolicies:
  - customPolicy:
      name: weighted_round_robin
      data: '{ "enableOobLoadReport": true }'

cc. @anicr7

@YifeiZhuang YifeiZhuang requested a review from temawi June 27, 2024 22:25
Copy link
Contributor

@temawi temawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the two comments. Check out why the checks are failing.

@YifeiZhuang YifeiZhuang merged commit 9e21459 into grpc:master Jun 27, 2024
13 checks passed
@YifeiZhuang YifeiZhuang deleted the xds branch June 27, 2024 23:55
larry-safran pushed a commit to larry-safran/grpc-java that referenced this pull request Jun 28, 2024
larry-safran pushed a commit to larry-safran/grpc-java that referenced this pull request Aug 13, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants