Improve test client for real cert #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test client can now be used against a server that has properly configured certificates, instead of just the test server. To reach the test server, the client needs these arguments: --use_test_ca=true --server_host_override=foo.test.google.fr Client no longer has any required arguments, although for any given setup needing to specify at least one argument is highly likely. The arguments have been improved in general to hopefully be more orthogonal and match those of other language's test clients.
|
@ejona86 LGTM ... feel free to cherrypick. |
|
Rebased and pushed as 6239965 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test client can now be used against a server that has properly
configured certificates, instead of just the test server. To reach the
test server, the client needs these arguments:
--use_test_ca=true --server_host_override=foo.test.google.fr
Client no longer has any required arguments, although for
any given setup needing to specify at least one argument is highly
likely.
The arguments have been improved in general to hopefully be more
orthogonal and match those of other language's test clients.