Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to a non-snapshot version of OkHttp #15

Closed
wants to merge 1 commit into from

Conversation

maniksurtani
Copy link
Contributor

No description provided.

@JakeWharton
Copy link
Contributor

See #2 and #3. Although now maybe we it's the right time to do this.

@ejona86
Copy link
Member

ejona86 commented Jan 16, 2015

Yeah, this is probably the right time to do this. The main question is how we want to deal with square/okhttp#1305 . We can either downgrade to 2.1.0, or upgrade as is here and just know we can't run on older versions of Android until the issue is resolved.

Downgrading is what I am considering most strongly, so I can keep our internal code synced more closely with this repo, but that would be a problem the moment the issue isn't fixed and some other bug/feature is needed in a newer version of okhttp. Thus, I'm fine either way.

Thoughts?

@JakeWharton
Copy link
Contributor

Yeah. I would downgrade for now. We'll fix NPN in the next version.

@ejona86
Copy link
Member

ejona86 commented Jan 26, 2015

Okay... Soo... Yeah...

Internally we are now patching NPN support back to okhttp, at least enough for our own usage. Since gRPC is currently requiring you to pass a pre-configured SslSocketFactory, you can use gRPC with NPN/ALPN without any support from okhttp. So there are no more blockers of using OkHttp 2.2.0.

@ejona86
Copy link
Member

ejona86 commented Jan 26, 2015

Pulled as 0ca6584

@ejona86 ejona86 closed this Jan 26, 2015
@ejona86
Copy link
Member

ejona86 commented Jan 27, 2015

@maniksurtani, I can't find a corporate CLA for Square. I was thinking y'all had one, but maybe I'm mistaken and y'all haven't filled out https://developers.google.com/open-source/cla/corporate ?

@maniksurtani
Copy link
Contributor Author

Let me chk with others @ Square

On 26 January 2015 at 16:04, Eric Anderson notifications@github.com wrote:

@maniksurtani https://github.com/maniksurtani, I can't find a corporate
CLA for Square. I was thinking y'all had one, but maybe I'm mistaken and
y'all haven't filled out
https://developers.google.com/open-source/cla/corporate ?


Reply to this email directly or view it on GitHub
#15 (comment).

@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants