core: Inline AbstractManagedChannelImplBuilder #7424
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7211.
Note to reviewers
Commit 75cccde preserves the order and style of
AbstractManagedChannelImplBuilder
inManagedChannelImplBuilder
, to highlight the changes necessary to inline the superclass:And the changes made to tests (mostly unchanged):
The following commit `cc0185c` organizes the methods and properties in `ManagedChannelImplBuilder` after inlining the superclass: 1. Package-private mutable state used for building`ManagedChannelImpl` is separated from private states and constants 2. Methods implementing `ManagedChannelBuilder` preserve the order they're defined in `ManagedChannelBuilder` 3. Private and `@VisibleForTesting` methods moved next to where they are executed or fit logically.