Remove proto size restriction when parsing protos. #836
Conversation
| CodedInputStream codedInput = CodedInputStream.newInstance(stream); | ||
| codedInput.setSizeLimit(Integer.MAX_VALUE); | ||
|
|
||
| return parser.parseFrom(codedInput); |
There was a problem hiding this comment.
In the documentation for parseFrom(CodedInputStream):
Note: The caller should call CodedInputStream#checkLastTagWas(int) after calling this to verify that the last tag seen was the appropriate end-group tag, or zero for EOF.
In my comment in #832, I say:
The only gotcha I see is that we need to call
checkLastTagWas(0)afterward.
There was a problem hiding this comment.
Ah good catch ... missed that. Done!
|
@ejona86 PTAL |
|
Do we want to do the same thing that proto does if the message was incomplete? try {
codedInput.checkLastTagWas(0);
} catch (InvalidProtocolBufferException e) {
throw e.setUnfinishedMessage(message);
}That does actually look useful, as you can piece together what the message was a bit, but aren't accidentally going to trust it. That does seem useful for debugging. |
| // when parsing. | ||
| CodedInputStream codedInput = CodedInputStream.newInstance(stream); | ||
| codedInput.setSizeLimit(Integer.MAX_VALUE); | ||
| codedInput.checkLastTagWas(0); |
There was a problem hiding this comment.
This has to happen after parseFrom() to have any purpose.
|
@ejona86 PTAL |
|
@nmittler LGTM |
|
Cherry-picked as 573f79a |
@ejona86 PTAL .. this is the first part of the change to support maxMessageSize.