Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Provider use in AndroidChannelBuilder and okhttp compileOnly #9039

Closed
wants to merge 2 commits into from
Closed

Revert Provider use in AndroidChannelBuilder and okhttp compileOnly #9039

wants to merge 2 commits into from

Commits on Mar 31, 2022

  1. Partly revert "okhttp: make okhttp dependencies compile only (grpc#8971… 

    …)"

This partly reverts b20ce17 because it is dependent on cda0e9d which is
being reverted as it is incompatible with Proguard without configuration
(e.g., isAvailable() may not be available and would need a -keep).

While the code no longer uses compileOnly, the compatibility still
remains, so it would be possible for users to exclude the okhttp
dependency if they don't use AndroidChannelBuilder.
    @ejona86
    ejona86 committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    99f78c4 View commit details
    Browse the repository at this point in the history

  2. Revert "android: Use Provider to construct OkHttpChannelBuilder" 

    This reverts commit cda0e9d. The change
was incompatible with Proguard without additional configuration. For
example, isAvailable() may not be available and would need a -keep.
    @ejona86
    ejona86 committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    58cdcf5 View commit details
    Browse the repository at this point in the history