Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repositories.bzl: Use valid target name for grpc-services (1.48.x backport) #9430

Merged
merged 1 commit into from
Aug 6, 2022

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Aug 6, 2022

This fixes builds including dependencies from Maven that use
io.grpc:grpc-services. It resolves this error:

no such target '@io_grpc_grpc_java//services:services': target 'services' not declared in package 'services' defined by services/BUILD.bazel and referenced by '@maven//:io_grpc_grpc_services'

Fixes #9419

CC @xushaoxiao

Backport of #9422

This fixes builds including dependencies from Maven that use
io.grpc:grpc-services or io.grpc:grpc-xds. It resolves this error:
```
no such target '@io_grpc_grpc_java//services:services': target 'services' not declared in package 'services' defined by services/BUILD.bazel and referenced by '@maven//:io_grpc_grpc_services'
```

Fixes grpc#9419
Copy link
Contributor

@sanjaypujare sanjaypujare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejona86 ejona86 merged commit 045d8e6 into grpc:v1.48.x Aug 6, 2022
@ejona86 ejona86 deleted the backport-bazel-services_maven-1.48 branch August 6, 2022 00:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants