Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netty: upgrade from 4.1.77.Final to 4.1.79.Final and tcnative 2.0.53 to 2.0.54 #9451

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

YifeiZhuang
Copy link
Contributor

No description provided.

@ejona86
Copy link
Member

ejona86 commented Aug 19, 2022

We should test the new version in Google to increase testing to detect regressions.

@YifeiZhuang
Copy link
Contributor Author

We should test the new version in Google to increase testing to detect regressions.

it looks TAP tests are fine: https://test.corp.google.com/OCL:468792239:BASE:468748860:1660946664413:3be01d1b

@ejona86
Copy link
Member

ejona86 commented Aug 22, 2022

That test didn't test anything; those files have no impact. You need to do a netty and tcnative import. We can discuss separately how.

@YifeiZhuang YifeiZhuang merged commit 0a699ad into grpc:master Aug 31, 2022
@YifeiZhuang YifeiZhuang deleted the netty-upgrade branch August 31, 2022 23:02
@sergiitk sergiitk changed the title netty: upgrade from 4.1.77.Final to 4.1.29.Final and tcnative 2.0.53 to 2.0.54 netty: upgrade from 4.1.77.Final to 4.1.79.Final and tcnative 2.0.53 to 2.0.54 Sep 7, 2022
larry-safran pushed a commit to larry-safran/grpc-java that referenced this pull request Oct 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants