Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Don't delegate inappropriate ConfigSelector errors #9536

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

temawi
Copy link
Contributor

@temawi temawi commented Sep 12, 2022

In case a control plane returns an "inappropriate" response code, it is converted to INTERNAL to highlight the bug in the control plane.

https://github.com/grpc/proposal/blob/master/A54-restrict-control-plane-status-codes.md

@temawi temawi requested a review from ejona86 September 12, 2022 18:43
@temawi temawi force-pushed the inappropriate-configselector-errors branch 3 times, most recently from 909e993 to 367cba0 Compare September 12, 2022 19:10
In case a control plane returns an "inappropriate" response code, it is converted to INTERNAL to highlight the bug in the control plane.

https://github.com/grpc/proposal/blob/master/A54-restrict-control-plane-status-codes.md
@temawi temawi force-pushed the inappropriate-configselector-errors branch from 367cba0 to 0955a80 Compare September 12, 2022 19:27
@temawi temawi merged commit 9853a0c into grpc:master Sep 12, 2022
larry-safran pushed a commit to larry-safran/grpc-java that referenced this pull request Oct 6, 2022
In case a control plane returns an "inappropriate" response code, it is converted to INTERNAL to highlight the bug in the control plane.

https://github.com/grpc/proposal/blob/master/A54-restrict-control-plane-status-codes.md
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants