Fix problem with underscores in rpc names #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lowasser
reviewed
May 13, 2020
| @@ -39,6 +39,16 @@ data class MemberSimpleName(val name: String) : CharSequence by name { | |||
| val OPERATOR_MINUS_ASSIGN = MemberSimpleName("minusAssign") | |||
| } | |||
|
|
|||
| fun handleSpecialCharacters(): MemberSimpleName{ | |||
There was a problem hiding this comment.
Missing a space before the { and, on the next line, after the if.
lowasser
reviewed
May 13, 2020
| @@ -23,7 +23,7 @@ import com.google.protobuf.Descriptors.MethodDescriptor | |||
| /** Represents the unqualified name of an RPC method in a proto file, in UpperCamelCase. */ | |||
| data class ProtoMethodName(val name: String) : CharSequence by name { | |||
| fun toMemberSimpleName(): MemberSimpleName = | |||
| MemberSimpleName(CaseFormat.UPPER_CAMEL.to(CaseFormat.LOWER_CAMEL, name)) | |||
| MemberSimpleName(CaseFormat.UPPER_CAMEL.to(CaseFormat.LOWER_CAMEL, name)).handleSpecialCharacters() | |||
There was a problem hiding this comment.
This honestly looks like the processing ought to happen here, not in MemberSimpleName.
There was a problem hiding this comment.
Moved code from MemberSimpleName and split into two methods
bshaffer
reviewed
May 14, 2020
| package io.grpc.testing.underscore; | ||
| option java_multiple_files = true; | ||
| service NameContainsUnderscore { | ||
| rpc say_hello (HelloRequest) returns (HelloReply); |
There was a problem hiding this comment.
Can we add a test case for say_hello_again?
There was a problem hiding this comment.
I added say_hello_again to proto and also unit test for this case to verify the behavior for names with multiple underscores
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #94
Added underscore in method name support.
Also added example of proto file and test for new behavior.