grpc-js-xds: Shutdown the xDS client used by the resolver when the channel shuts down #1641
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A channel that connects to an
xds:///
backend creates an internal client connected to an xDS server. Currently that client just always has an active call and holds the process open forever. This change makes it so that when that channel'sclose
method is called, which calls its resolving load balancer'sdestroy
method, that propagates to destroy the resolver, which then shuts down the xDS client, allowing the process to end.Technically, this is a breaking change in the
experimental
namespace by adding an additional method to theResolver
interface that would need to be implemented by an implementing class. However, the real point of theexperimental
version compatibility guarantees is to avoid breaking grpc-js-xds, and since that's not out yet I don't consider it to be a real issue.