Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ordo-one/package-benchmark #1678

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

gjcairo
Copy link
Collaborator

@gjcairo gjcairo commented Oct 18, 2023

Motivation

We want to adopt ordo-one/package-benchmark for benchmarking grpc-swift.

Modifications

This sets up package-benchmark in the project and in the CI, but doesn't actually yet add any benchmarks. Old allocation tests have not been removed.

Result

Everything is set up to add benchmarks in the future.

@gjcairo gjcairo force-pushed the gc-package-benchmark branch 3 times, most recently from 30b86ab to 44980a9 Compare October 18, 2023 15:50
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
Benchmarks/.gitignore Outdated Show resolved Hide resolved
Benchmarks/Package.swift Outdated Show resolved Hide resolved
@gjcairo gjcairo marked this pull request as ready for review October 19, 2023 09:17
@gjcairo gjcairo force-pushed the gc-package-benchmark branch 2 times, most recently from fe3c743 to 5d6dbb2 Compare October 19, 2023 09:48
Package.swift Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fab. Thanks Gus.

@gjcairo gjcairo requested a review from glbrntt October 19, 2023 12:31
@glbrntt glbrntt added the semver/none No version change required. label Oct 19, 2023
@glbrntt glbrntt merged commit 99e9956 into grpc:main Oct 19, 2023
14 checks passed
@gjcairo gjcairo deleted the gc-package-benchmark branch October 19, 2023 12:41
@glbrntt glbrntt added the v2 A change for v2 label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version change required. v2 A change for v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants