-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TS Top Level Enums are not imported correctly #454
Comments
rogchap
added a commit
to SafetyCulture/grpc-web
that referenced
this issue
Feb 5, 2019
Thanks for finding this ;-) |
stanley-cheung
added a commit
to stanley-cheung/grpc-web
that referenced
this issue
Feb 27, 2019
stanley-cheung
added a commit
that referenced
this issue
Feb 27, 2019
loyalpartner
pushed a commit
to loyalpartner/grpc-web
that referenced
this issue
Sep 4, 2020
* Allow non root resources * code review * code review * code review * code review * add non root resource test * add non root resource test * add non root resource test * code review * code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As a result of: #433
@shaxbee Firstly, thank you for this PR, makes for much better typings.
I've noticed that this has caused a side-effect with importing top level enums that are imported;
message
s seem to be correctly referenced butenum
s are not. In the below example I would expectStatus
to bestatus_pb.Status
in the*.d.ts
Input:
Output:
The text was updated successfully, but these errors were encountered: