Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Bazel in Javascript toolchain #1138

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

sampajano
Copy link
Collaborator

@sampajano sampajano commented Sep 22, 2021

Summary

  • Removes closure_js_library targets for they're no longer used for neither release or testing.
  • Also removes closure_grpc_web_library and grpc_web_toolchain, for they depend on rules_closure, and hence an older version of Closure than what's used for release and testing.

@sampajano sampajano marked this pull request as ready for review September 22, 2021 05:01
Copy link
Collaborator

@stanley-cheung stanley-cheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing this home. We are that much closer to being able to sync now!

@stanley-cheung
Copy link
Collaborator

@Yannic FYI about this PR.

We were having trouble (#1082) syncing code between our internal code base with Github here because rules_closure is embedding an outdated version of Closure.

@sampajano helped us migrate to be using Protractor to run the jsunit tests (#1137) instead of relying on bazel. Hence a lot of those closure bazel rules are no longer needed.

Since you have contributed a lot to this area in the past so we'd like to get your attention on this. Thank you so much contributing! And just to clarify, we will still be using bazel for other purposes in this repo (the cpp generator, etc). We only migrated away the piece where we were using bazel to run the closure jsunit tests away.

Thanks!

@sampajano
Copy link
Collaborator Author

@Yannic Yeah thanks so much for contributions in the past.. I can see it's quite a lot of work.. And sorry for deleting it.. (But at least the code will be remembered forever by Github just in case we might need it one day in the future :P)

@sampajano sampajano merged commit 78ddf99 into grpc:master Sep 22, 2021
@sampajano sampajano deleted the 1-cleanup-bazel-js branch September 22, 2021 06:19
@sampajano sampajano changed the title Clean up Javascript-related Bazel rules. Remove Bazel in the Javascript toolchain. Oct 13, 2021
@sampajano sampajano changed the title Remove Bazel in the Javascript toolchain. Remove Bazel in the Javascript toolchain Oct 13, 2021
@sampajano sampajano changed the title Remove Bazel in the Javascript toolchain Remove Bazel in Javascript toolchain Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants