Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to prevent Envoy to timeout streaming #311

Merged
merged 1 commit into from
Oct 6, 2018

Conversation

mitar
Copy link
Contributor

@mitar mitar commented Oct 6, 2018

Fixes #309.

The example is missing this option, so all streaming calls get terminated after 15 seconds, if there is no message sent.

Copy link
Collaborator

@stanley-cheung stanley-cheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great find! Thanks again for all the great contributions!

@stanley-cheung stanley-cheung merged commit 8289574 into grpc:master Oct 6, 2018
@mitar
Copy link
Contributor Author

mitar commented Oct 6, 2018

So now just that #307 is fixed and I will have a fully interoperable client in browser. It works really cool otherwise. Thanks for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If stream messages take long, streaming disconnects
3 participants