Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit status event on empty stream response #413

Merged
merged 2 commits into from
Jan 8, 2019

Conversation

shaxbee
Copy link
Contributor

@shaxbee shaxbee commented Dec 18, 2018

When stream is closed immediately by the server grpc-status and grpc-message headers are populated.
Current implementation is broken as it does not fire status or end event in that case.

@shaxbee shaxbee force-pushed the empty-stream-status branch 3 times, most recently from 713ef5a to 63414d2 Compare December 18, 2018 10:46
@shaxbee
Copy link
Contributor Author

shaxbee commented Dec 19, 2018

@stanley-cheung Done! :-)

@shaxbee shaxbee force-pushed the empty-stream-status branch 2 times, most recently from 476b52f to 2f4051d Compare December 19, 2018 08:49
@shaxbee
Copy link
Contributor Author

shaxbee commented Dec 21, 2018

Fixed issues reported by kokoro.

@stanley-cheung
Copy link
Collaborator

@shaxbee There seems to be still some error reported by Kokoro. Please take a look. Thanks!

@shaxbee
Copy link
Contributor Author

shaxbee commented Jan 8, 2019

@stanley-cheung Sorry, missed that one :-)

Copy link
Collaborator

@stanley-cheung stanley-cheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants