fix: exclude map entry message from typings, fix optional values #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaxbee
force-pushed
the
map-asobject
branch
2 times, most recently
from
49d3ba4
to
caa69c1
Compare
|
Sorry for the late look at this. There had been some work to re-sync this repo with our internal codebase so it looks like there are some new conflicts. Can you please resolve them and rebase to the latest master please? Thanks |
shaxbee
force-pushed
the
map-asobject
branch
from
3b09ff8
to
ae53a4e
Compare
|
@stanley-cheung Rebased :-) |
stanley-cheung
approved these changes
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings bindings in line with
ts-protoc-gen.Do not generate typings for proto
mapentry type.Fix optionality of
repeatedfields - array fields are required.Add
has$field_name$method for message fields.Add
add$element_name$method for repeated fields.Support
[jstype=JS_STRING]field option.Prefix reserved fields in AsObject with
pb_prefix.Example:
https://github.com/shaxbee/grpc-web-dts-example/blob/master/map-asobject/example/example_pb.d.ts