Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure credentials are not undefined in typescript #582

Merged
merged 2 commits into from
Jul 1, 2019

Conversation

Globegitter
Copy link
Contributor

Fixes #581

Just needed a fix for it so already submitted a PR. Let me know if you want to fix this differently.

Copy link
Collaborator

@stanley-cheung stanley-cheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanley-cheung stanley-cheung merged commit db6cd68 into grpc:master Jul 1, 2019
@Globegitter Globegitter deleted the patch-1 branch July 2, 2019 06:24
loyalpartner pushed a commit to loyalpartner/grpc-web that referenced this pull request Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript credentials type issue
3 participants