Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Helloworld Example - Enabled Deprecation #593

Merged
merged 2 commits into from
Jul 20, 2019

Commits on Jul 18, 2019

  1. Fix: Helloworld Example - Enabled Deprecation

    Fixes Envoy not starting up due to https://www.envoyproxy.io/docs/envoy/latest/intro/deprecated
    ```
    [2019-07-18 01:48:05.301][7][critical][main] [source/server/server.cc:93] error initializing configuration '/etc/envoy/envoy.yaml': Proto constraint validation failed (Using deprecated option 'envoy.api.v2.route.CorsPolicy.enabled' from file route.proto. This configuration will be removed from Envoy soon. Please see https://www.envoyproxy.io/docs/envoy/latest/intro/deprecated for details. If continued use of this field is absolutely necessary, see https://www.envoyproxy.io/docs/envoy/latest/configuration/runtime#using-runtime-overrides-for-deprecated-features for how to apply a temporary and highly discouraged override.): allow_origin: "*"
    allow_methods: "GET, PUT, DELETE, POST, OPTIONS"
    allow_headers: "keep-alive,user-agent,cache-control,content-type,content-transfer-encoding,custom-header-1,x-accept-content-transfer-encoding,x-accept-response-streaming,x-user-agent,x-grpc-web,grpc-timeout"
    expose_headers: "custom-header-1,grpc-status,grpc-message"
    max_age: "1728000"
    enabled {
      value: true
    }
    
    [2019-07-18 01:48:05.301][7][info][main] [source/server/server.cc:560] exiting
    Proto constraint validation failed (Using deprecated option 'envoy.api.v2.route.CorsPolicy.enabled' from file route.proto. This configuration will be removed from Envoy soon. Please see https://www.envoyproxy.io/docs/envoy/latest/intro/deprecated for details. If continued use of this field is absolutely necessary, see https://www.envoyproxy.io/docs/envoy/latest/configuration/runtime#using-runtime-overrides-for-deprecated-features for how to apply a temporary and highly discouraged override.): allow_origin: "*"
    allow_methods: "GET, PUT, DELETE, POST, OPTIONS"
    allow_headers: "keep-alive,user-agent,cache-control,content-type,content-transfer-encoding,custom-header-1,x-accept-content-transfer-encoding,x-accept-response-streaming,x-user-agent,x-grpc-web,grpc-timeout"
    expose_headers: "custom-header-1,grpc-status,grpc-message"
    max_age: "1728000"
    enabled {
      value: true
    }
    ```
    gary-lo authored Jul 18, 2019
    Configuration menu
    Copy the full SHA
    b2a29aa View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2019

  1. Configuration menu
    Copy the full SHA
    6b011ee View commit details
    Browse the repository at this point in the history