Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a 'goog_promise' option to generator #879

Merged
merged 2 commits into from
Jul 3, 2020
Merged

Add a 'goog_promise' option to generator #879

merged 2 commits into from
Jul 3, 2020

Conversation

stanley-cheung
Copy link
Collaborator

Internal change

author:@Jennnnny

@stanley-cheung stanley-cheung merged commit e0835e2 into grpc:master Jul 3, 2020
@stanley-cheung stanley-cheung deleted the grpc-web-promise branch July 3, 2020 05:52
@Yannic Yannic mentioned this pull request Jul 5, 2020
Merged
@Yannic
Copy link
Contributor

Yannic commented Jul 5, 2020

@stanley-cheung Using this requires a type grpc.web.promise.GrpcWebPromise that doesn't exist (yet). Is this intentional or was it an oversight?

@stanley-cheung
Copy link
Collaborator Author

@Yannic This is supposed to be an internal feature. I thought that if we don't do anything, the grpc.web.promise.GrpcWebPromise will not be included in the generated file? I will double check tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stanley-cheung @Yannic