The path to Grpc.Tools in the example command for Linux(or macOS) does not exist #784
Conversation
|
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
|
I signed it |
|
@jtattermusch can you take a look? |
| @@ -164,7 +164,7 @@ protoc-gen-grpc plugin requires fullpath of "grpc_csharp_plugin" executable inst | |||
|
|
|||
| ``` | |||
| # Local nuget cache on Linux and Mac is located in ~/.nuget/packages | |||
| $ ~/.nuget/packages/grpc.tools.{{ site.data.config.grpc_release_tag | remove_first: "v" }}/tools/linux_x64/protoc -I../../protos --csharp_out Greeter --grpc_out Greeter ../../protos/helloworld.proto --plugin=protoc-gen-grpc=${HOME}/.nuget/packages/grpc.tools.{{ site.data.config.grpc_release_tag | remove_first: "v" }}/tools/linux_x64/grpc_csharp_plugin | |||
There was a problem hiding this comment.
we might need to fix the path for windows too.
|
@ptrkrlsrd can you please sign the CLA? Otherwise I can't merge. |
|
Btw, in the upcoming release v1.17.0 we will have experimental support for codegen integration (see https://github.com/grpc/grpc/blob/master/src/csharp/BUILD-INTEGRATION.md), so juggling with grpc.tools path should not be necessary anymore. |
|
@jtattermusch Hey, I signed it right after creating the pull request. But maybe something went wrong in the process. I'll have a look Edit: |
Hey,
I belive there is a mistake in the path to Grpc.Tools in the example command for Linux in the documentation. When I tried running the example command displayed on the page (look below) I got an error saying that the path does not exist. It worked when I replaced the dot after tools in the current path (
~.nuget/packages/grpc.tools.1.16.0/) with a slash, which resulted in a valid path:~/.nuget/packages/grpc.tools/1.16.0/