Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cmake improvements blogpost #121

Merged
merged 3 commits into from
Mar 16, 2020
Merged

Add cmake improvements blogpost #121

merged 3 commits into from
Mar 16, 2020

Conversation

jtattermusch
Copy link
Contributor

@jtattermusch jtattermusch commented Mar 6, 2020 •
edited
Loading

A have a few more TODOs in the text, but once I resolve them, this can be published.

@jtattermusch
Copy link
Contributor Author

CC @zackgalbreath

zackgalbreath
zackgalbreath suggested changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@zackgalbreath zackgalbreath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor tweaks

content/blog/2020-03-06-cmake-improvements.md Outdated Show resolved Hide resolved
content/blog/2020-03-06-cmake-improvements.md Outdated Show resolved Hide resolved
@jtattermusch
Copy link
Contributor Author

Addressed comments, unless there is more concerns, this is good for final review and I'll merge after that.

The preview link here:
https://deploy-preview-121--grpc-io.netlify.com/blog/cmake-improvements/

@lucperkins
Copy link
Contributor

@jtattermusch Could you rebase against master first so we can see the deploy preview for the updated site template?

@jtattermusch
Copy link
Contributor Author

Rebased.

@jtattermusch
Copy link
Contributor Author

It this good to merge now?

@jtattermusch jtattermusch mentioned this pull request Mar 16, 2020
Closed
@zackgalbreath
Copy link
Contributor

The "View File" preview is still showing

GIT_TAG        {{< param grpc_release_tag >}}

If that's intended, or will otherwise be replaced, then ignore this commit.

Otherwise everything LGTM!

@jtattermusch
Copy link
Contributor Author

The "View File" preview is still showing

GIT_TAG        {{< param grpc_release_tag >}}

If that's intended, or will otherwise be replaced, then ignore this commit.

Otherwise everything LGTM!

In this preview link you can see that it's rendered correctly:
https://deploy-preview-121--grpc-io.netlify.com/blog/cmake-improvements/

@jtattermusch
Copy link
Contributor Author

@lucperkins @thisisnotapril can you approve so I can merge?

@chalin
Copy link
Collaborator

chalin commented Mar 16, 2020

A quick copyediting pass would be needed, but that can be done after this is merged. I'll let Luc give the final thumbs up.

chalin
chalin reviewed Mar 16, 2020
View reviewed changes
content/blog/2020-03-06-cmake-improvements.md
author: Zack Galbreath
author-link: https://github.com/zackgalbreath
date: "2020-03-06T00:00:00Z"
published: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think that we need a this published: true entry.

@lucperkins
Copy link
Contributor

I'm going to make some of the requested non-content changes myself (filename, params, etc.)

@lucperkins lucperkins merged commit f2a2190 into grpc:master Mar 16, 2020
@QuantumGhost QuantumGhost mentioned this pull request Mar 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin left review comments

@zackgalbreath zackgalbreath zackgalbreath requested changes

@lucperkins lucperkins lucperkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jtattermusch @lucperkins @zackgalbreath @chalin