-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invalid version .so links in Makefile #16832
Conversation
|
|
|
|
Hi, I don't think that these three CI builds failed due to my changes. Is it possible to retry the build? |
Gentle ping @nicolasnoble @jtattermusch |
cb29a2a
to
3a0faa4
Compare
I reran generate_projects.sh and fixed-up the "Regenerate projects" commit in this PR to apply cleanly on top of the current master branch. |
Over a month passed since I created this PR. No response? @jtattermusch @nicolasnoble |
|
|
|
Summary: E.g.
The PR seems to correctly fix the problem, thanks for the fix! |
@@ -1370,7 +1370,7 @@ | |||
ifeq ($(SYSTEM),MINGW32) | |||
$(Q) $(INSTALL) $(LIBDIR)/$(CONFIG)/lib${lib.name}$(SHARED_VERSION_${lang_to_var[lib.language]})-dll.a $(prefix)/lib/lib${lib.name}.a | |||
else ifneq ($(SYSTEM),Darwin) | |||
$(Q) ln -sf $(SHARED_PREFIX)${lib.name}$(SHARED_VERSION_${lang_to_var[lib.language]}).$(SHARED_EXT_${lang_to_var[lib.language]}) $(prefix)/lib/lib${lib.name}.so.${settings.core_version.major} | |||
$(Q) ln -sf $(SHARED_PREFIX)${lib.name}$(SHARED_VERSION_${lang_to_var[lib.language]}).$(SHARED_EXT_${lang_to_var[lib.language]}) $(prefix)/lib/lib${lib.name}.so.${settings.get(lang_to_var[lib.language].lower() + '_version').major} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FTR, the expression ${settings.get(lang_to_var[lib.language].lower() + '_version').major}
is taken from https://github.com/grpc/grpc/pull/10303/files#diff-7b747c345348de73c8376cf79e5958f3R1562 (and that seems correct).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The links to the .so files previously used a
${settings.core_version.major}
suffix for C, C++ and C#, which is incorrect.Instead append the core major version for C, the cpp major version for C++ and the csharp major version for C# links.
This fixes an "error while loading shared libraries .. cannot open shared object file.." on an embedded Linux application which was linked dynamically to libgrpc++.