Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded lodash to 4+ #7981

Closed
wants to merge 1 commit into from
Closed

Upgraded lodash to 4+ #7981

wants to merge 1 commit into from

Conversation

odino
Copy link

@odino odino commented Sep 4, 2016

Hola people!

Was playing around with grpc on node and realized it requires an older version of lodash -- in the spirit of keeping everything updated I'm sending this.

  • package.json is updated
  • _.object became _.fromPairs (ref)

Ran npm test and everything seems fine -- let me know if any issue! :)

~/projects/grpc (master ✘) ✹✭ ᐅ npm test

> grpc@1.1.0-dev test /home/odino/projects/grpc
> mocha src/node/test && npm run-script lint



  Async functionality
    ✓ should not hang

...
...
...

  203 passing (5s)
  2 pending


> grpc@1.1.0-dev lint /home/odino/projects/grpc
> node ./node_modules/jshint/bin/jshint src/node/src src/node/test src/node/interop src/node/index.js --exclude-path=src/node/.jshintignore

@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

1 similar comment
@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

1 similar comment
@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

@murgatroid99
Copy link
Member

Thanks for the pull request, but this change is already part of the pending change in #7738.

@odino
Copy link
Author

odino commented Sep 6, 2016

WHAT''s the ETA for #7738 to make it to master? :)

@murgatroid99
Copy link
Member

Probably soon after it gets merged. And it shouldn't matter, exactly, because we publish from branches anyway.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants