A66 update: Update OpenTelemetry Java APIs #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashykt
reviewed
May 21, 2024
| `grpc.method` attribute. If you are interested in recording the method names for | ||
| these methods, set | ||
| [`isSampledToLocalTracing`](https://grpc.github.io/grpc-java/javadoc/io/grpc/MethodDescriptor.html#isSampledToLocalTracing\(\)) | ||
| to `true` while defining your methods in | ||
| [`HandlerRegistry`](https://grpc.github.io/grpc-java/javadoc/io/grpc/HandlerRegistry.html). | ||
| - A single `GrpcOpenTelemetry` instance can be registered either globally or on a |
There was a problem hiding this comment.
why is the behavior unexpected?
There was a problem hiding this comment.
It collects and exports duplicated data. In OpenCensus writing identical metric more than once throws identical time series error.
Since the identical time series issue has not been verified in OpenTelemetry, updated the note to say duplicated data.
yashykt
approved these changes
May 21, 2024
markdroth
changed the title
ejona86
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.