Update A14-channelz.md to use RFC ciphersuite names #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The standard ciphersuite name already includes both the key exchange and the cipher. The naming convention is: `TLS_<key_exchange>_WITH_<cipher>_<hash>`: https://tools.ietf.org/html/rfc4346#appendix-C I confirmed the Java SSL API provides an easy way to get this standard name. For C, there is https://www.openssl.org/docs/manmaster/man3/SSL_CIPHER_get_name.html: >> SSL_CIPHER_standard_name() returns a pointer to the standard RFC name of cipher. If the cipher is NULL, it returns "(NONE)". If the cipher has no standard name, it returns NULL. If cipher was defined in both SSLv3 and TLS, it returns the TLS name. For Go: https://golang.org/pkg/crypto/tls/#pkg-constants
A14-channelz.md
Outdated
| string cipher_suite_standard_name = 1; | ||
| // Some other way to describe the cipher suite if | ||
| // the RFC 4346 name is not available. | ||
| string cipher_suite_other_name = 2; |
There was a problem hiding this comment.
Maybe this should be:
oneof cipher_suite {
string standard_name = 1;
string other_name = 2;
} There was a problem hiding this comment.
done @carl-mastrangelo PTAL
carl-mastrangelo
approved these changes
Mar 16, 2018
zpencer
added a commit
to zpencer/grpc-java
that referenced
this pull request
Mar 16, 2018
zpencer
added a commit
to grpc/grpc-java
that referenced
this pull request
Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard ciphersuite name already includes both the key exchange and the cipher. The naming convention is:
TLS_<key_exchange>_WITH_<cipher>_<hash>:https://tools.ietf.org/html/rfc4346#appendix-C
Just exposing the RFC name lets us avoid string parsing in every channelz implementation. It also exposes the hash algorithm for free.
I confirmed the Java SSL API provides an easy way to get this standard name.
For C, there is https://www.openssl.org/docs/manmaster/man3/SSL_CIPHER_get_name.html:
For Go:
https://golang.org/pkg/crypto/tls/#pkg-constants