Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ClientDeploymentArgs #83

Merged
merged 2 commits into from
May 14, 2024
Merged

Conversation

sergiitk
Copy link
Member

@sergiitk sergiitk commented May 13, 2024

Introduces ClientDeploymentArgs, similar to already existing ServerDeploymentArgs.

Helps with decluttering KubernetesClientRunner class arguments. With this class, no need to create new runner arguments just to pass it to the deployment template.

@sergiitk
Copy link
Member Author

FYi @stanley-cheung

@sergiitk sergiitk marked this pull request as draft May 14, 2024 00:10
@sergiitk
Copy link
Member Author

Ah. I accidentally changed a file I shouldn't have. Let me fix this.

@sergiitk
Copy link
Member Author

sergiitk commented May 14, 2024

New csm run:

@sergiitk sergiitk marked this pull request as ready for review May 14, 2024 00:17
@sergiitk
Copy link
Member Author

Fixed - ready for review again.

@sergiitk sergiitk changed the title Introduce ClientDeploymentArgs Introduce ClientDeploymentArgs May 14, 2024
@sergiitk
Copy link
Member Author

All tests passed - enabling automerge.

@sergiitk sergiitk enabled auto-merge (squash) May 14, 2024 16:16
@sergiitk sergiitk merged commit 70348ea into grpc:main May 14, 2024
7 checks passed
@sergiitk sergiitk deleted the client-deployment-args branch May 14, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants