Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add complete configuration for prometheus installation. #287

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

wanlin31
Copy link
Collaborator

@wanlin31 wanlin31 commented Mar 17, 2022

This commit add complete configurations for installing prometheus operator and prometheus.

@wanlin31 wanlin31 requested a review from paulosjca March 17, 2022 21:55
@wanlin31 wanlin31 marked this pull request as ready for review March 17, 2022 21:55
@wanlin31 wanlin31 self-assigned this Mar 17, 2022
@wanlin31 wanlin31 added the enhancement New feature or request label Mar 17, 2022
@paulosjca paulosjca added the release notes: yes Indicates that PR needs to be in release notes label Mar 20, 2022
Copy link
Collaborator

@paulosjca paulosjca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the note that we want to automate this deployment using the Makefile. This can be done in a follow-up PR.

@wanlin31
Copy link
Collaborator Author

wanlin31 commented Mar 26, 2022

LGTM with the note that we want to automate this deployment using the Makefile. This can be done in a follow-up PR.

Right, I have tried to apply all the file together use the following command, did not observe a need for specific order or wait time within them:

kubectl create -f config/prometheus/setup/

It will take about 50s to get the prometheus service fully functioning, I have also update the README.md.

This commit updates the installation command for prometheus and
add the verification-how-to for prometheus service.
@wanlin31 wanlin31 merged commit 2798395 into grpc:master Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request release notes: yes Indicates that PR needs to be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants