Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prometheus query to driver's run container. #289

Merged

Conversation

wanlin31
Copy link
Collaborator

@wanlin31 wanlin31 commented Mar 29, 2022

This commit asks the driver to run Prometheus query to obtain
cpu and memory data when running a PSM test. Currently a PSM test
is observed when SERVER_TARGET_OVERRIDE environment variable is
not empty.

In the future, running the query script would depend on if there are
Prometheus service running.

This PR has to be merged after grpc/grpc#29057
and grpc/grpc#29197.

@wanlin31 wanlin31 self-assigned this Mar 29, 2022
@wanlin31 wanlin31 added the release notes: yes Indicates that PR needs to be in release notes label Mar 29, 2022
@wanlin31 wanlin31 force-pushed the implement-prometheus-query-to-driver branch 3 times, most recently from ab0e292 to 2f15ef7 Compare March 29, 2022 20:41
This commit asks the driver to run prometheus queries to obtain
cpu and memory data when running a PSM test. Currently a PSM test
is observed when SERVER_TARGET_OVERRIDE environment variable is
not empty.
@wanlin31 wanlin31 force-pushed the implement-prometheus-query-to-driver branch from 2f15ef7 to e52cd29 Compare March 29, 2022 21:39
@wanlin31 wanlin31 requested a review from paulosjca March 30, 2022 02:39
@wanlin31 wanlin31 marked this pull request as ready for review March 30, 2022 02:39
@wanlin31 wanlin31 merged commit 2bfaef3 into grpc:master Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: yes Indicates that PR needs to be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants