Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #119 (UX 1) Added Progressbar during file Upload #127

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

d4nnyp73
Copy link

@d4nnyp73 d4nnyp73 commented Sep 7, 2023

I have added a funktioning Progressbar to indicate file upload Status. I have used axios for this.

I am new to contributing so feedback is much apprechiated.

Issue: improve user-experience 1 #119

progressbar

Added a visual Progressbar underneath the Dropzone to indicate the FileUpload-Progress
Adjusted Code
@vercel
Copy link

vercel bot commented Sep 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aixplora ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 11:11am

@grumpyp
Copy link
Owner

grumpyp commented Sep 7, 2023

Where is the Progress component? Did you forget to push it?

I imported it myself and tested it, the loading bar unfortunately doesn't represent any loading. Could you dig deeper into it and represent a loading according to the actual loading? Or a Notification which has a loading spinner or something? But this doesn't really improve the UI as of now.

Thanks a lot, I am up for any questions :)

@d4nnyp73
Copy link
Author

d4nnyp73 commented Sep 8, 2023

Thanks for the feedback :)

Yeah sure! Could you tell me which processes should be involved in the loading Process? Is it only the File Uploading or anything else to wait for? I think I already have an Idea what I did wrong. I try to make it work in the next few days!

@grumpyp
Copy link
Owner

grumpyp commented Sep 8, 2023

Thanks for the feedback :)

Yeah sure! Could you tell me which processes should be involved in the loading Process? Is it only the File Uploading or anything else to wait for? I think I already have an Idea what I did wrong. I try to make it work in the next few days!

Hi there :)

We have a loading in the Chat page too, but it's already implemented there. The same with the Summary page.

The config page is a matter of ms, so we won't need it there. The only issue as of now is the Files page.

So one possible approach would be to kind of index a db model and update it over the upload - not sure if that would be a perfect solution tho. In the frontend you could then query the status each second for example.

An easy solution would be to implement a loading spinner which is running during the request, as soon as it get's a response it should show the notification and hide the spinner additionally you could disable the upload button?

What do you think?

@d4nnyp73
Copy link
Author

d4nnyp73 commented Sep 11, 2023

Hey,
thanks for the info. I think your solutions sounds good enough. I havent done something like this in the backend before but I will try to get it done like you said.
The spinner is a good idea, maybe I can make it spin inside the upload button to indicate that it is not working during upload?

@grumpyp
Copy link
Owner

grumpyp commented Sep 11, 2023

Yes, lets do it like this.

Hey, thanks for the info. I think your solutions sounds good enough. I havent done something like this in the backend before but I will try to get it done like you said. The spinner is a good idea, maybe I can make it spin inside the upload button to indicate that it is not working during upload?

@grumpyp
Copy link
Owner

grumpyp commented Sep 29, 2023

Hi, any news? @d4nnyp73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants