-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clone/Copy #11
Comments
A copy() method would be useful. I'll add it. copy() is Python's nomenclature for a shallow copy (dict, set, deque, etc), over clone(). In the mean time, you can create an inline copy with furl() and base_url's URL string >>> copy = furl(base_url.url).set(path='/method/1') In testing for the above I found a bug - the furl() constructor should accept another furl object, not just a URL string. >>> f = furl('http://www.google.com/')
>>> copy = furl(f)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/local/lib/python2.7/dist-packages/furl/furl.py", line 659, in __init__
self.load(url) # Raises ValueError on invalid url.
File "/usr/local/lib/python2.7/dist-packages/furl/furl.py", line 668, in load
tokens = urlsplit(url) # Raises ValueError on malformed IPv6 address.
File "/usr/local/lib/python2.7/dist-packages/furl/furl.py", line 1022, in urlsplit
toks = urlparse.urlsplit(url)
File "/usr/lib/python2.7/urlparse.py", line 173, in urlsplit
i = url.find(':')
AttributeError: 'furl' object has no attribute 'find' I am consolidating both copy() and the furl() constructor bug in this issue, issue #11. Thanks for your suggestion martynsmith. |
copy() has been added to furl. >>> f = furl('http://www.google.com/')
>>> f.copy().set(path='/pumps').url
http://www.google.com/pumps
>>> f.url
http://www.google.com/ The furl init() bug has also been fixed. >>> f = furl('http://www.google.com/')
>>> copy = furl(f) Thanks for bringing this issue to my attention martynsmith. |
It would be nice if there was an inline method
clone
that returned a copy of the object. It would mean you could do things like:Without affecting the original
base_url
objectThe text was updated successfully, but these errors were encountered: