Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone/Copy #11

Closed
martynsmith opened this issue Feb 28, 2012 · 2 comments
Closed

Clone/Copy #11

martynsmith opened this issue Feb 28, 2012 · 2 comments

Comments

@martynsmith
Copy link

It would be nice if there was an inline method clone that returned a copy of the object. It would mean you could do things like:

base_url.clone().set({path: '/method/1'})

Without affecting the original base_url object

@gruns
Copy link
Owner

gruns commented Feb 28, 2012

A copy() method would be useful. I'll add it. copy() is Python's nomenclature for a shallow copy (dict, set, deque, etc), over clone().

In the mean time, you can create an inline copy with furl() and base_url's URL string

>>> copy = furl(base_url.url).set(path='/method/1')

In testing for the above I found a bug - the furl() constructor should accept another furl object, not just a URL string.

>>> f = furl('http://www.google.com/')
>>> copy = furl(f)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python2.7/dist-packages/furl/furl.py", line 659, in __init__
    self.load(url) # Raises ValueError on invalid url.
  File "/usr/local/lib/python2.7/dist-packages/furl/furl.py", line 668, in load
    tokens = urlsplit(url) # Raises ValueError on malformed IPv6 address.
  File "/usr/local/lib/python2.7/dist-packages/furl/furl.py", line 1022, in urlsplit
    toks = urlparse.urlsplit(url)
  File "/usr/lib/python2.7/urlparse.py", line 173, in urlsplit
    i = url.find(':')
AttributeError: 'furl' object has no attribute 'find'

I am consolidating both copy() and the furl() constructor bug in this issue, issue #11.

Thanks for your suggestion martynsmith.

@gruns
Copy link
Owner

gruns commented Mar 10, 2012

copy() has been added to furl.

>>> f = furl('http://www.google.com/')
>>> f.copy().set(path='/pumps').url
http://www.google.com/pumps
>>> f.url
http://www.google.com/

The furl init() bug has also been fixed.

>>> f = furl('http://www.google.com/')
>>> copy = furl(f)

Thanks for bringing this issue to my attention martynsmith.

@gruns gruns closed this as completed Mar 10, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants