Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto PEP8 #18

Merged
merged 2 commits into from
Oct 29, 2013
Merged

Auto PEP8 #18

merged 2 commits into from
Oct 29, 2013

Conversation

slick666
Copy link
Contributor

Ran autopep8 against codebase. Not tested.
https://pypi.python.org/pypi/autopep8

Ran autopep8 against codebase. Not tested.
https://pypi.python.org/pypi/autopep8
@gxx
Copy link

gxx commented Oct 17, 2013

you're going to have your name all over his code if this gets in, heh

@gxx
Copy link

gxx commented Oct 17, 2013

^ this will also conflict with my pull request, so whichever one merges in first, the second will have to re-merge master and fix the conflicts

@slick666
Copy link
Contributor Author

If there is a choice I would say have your changes go in first. Despite the line number counts this doesn't represent a whole lot of time on my part.

Some hands on cleaning. Mostly refactoring comments and string constants
@gxx
Copy link

gxx commented Oct 18, 2013

hm, if you check issues, there's an issue opened for pep8 2 years ago. i think this isn't going to get merged any time soon. non-pep8 code is so difficult to work with. i'm going to fork this for my own needs for now, as i have a lot more changes in mind

@gruns
Copy link
Owner

gruns commented Oct 19, 2013

The first commit, 34a4d1a, pushes lines beyond 80 characters. The latter appears to rectify the issue.

I'll inspect locally and verify everything is kosher before merging.

gruns pushed a commit that referenced this pull request Oct 29, 2013
…t2 as a test requirement for Python <= 2.6. Fixed a bug in Path.add() where in some cases the absoluteness of the Path wasn't preserved.
@gruns gruns merged commit 34a4d1a into gruns:master Oct 29, 2013
@gruns
Copy link
Owner

gruns commented Oct 29, 2013

Code now formatted to PEP8: commit 6df53fa + a manual review and tweaks.

Thank you for bringing this issue to my attention and for your pull requests, slick666 and Andrew.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants