Skip to content
This repository has been archived by the owner on May 20, 2018. It is now read-only.

Copy task minimatch options #105

Merged
merged 3 commits into from
Aug 16, 2012
Merged

Copy task minimatch options #105

merged 3 commits into from
Aug 16, 2012

Conversation

nnnnathann
Copy link
Contributor

Hi guys,

While using the copy task, I needed to include some dot files. This patch should allow for minimatch options to be passed through from the copy options object to the grunt.expandFiles function.

Example:

copy: {
  minimatch: {
    options: {
      minimatch: {
        dot: true
      }
    },
    files: {
      "fixtures/output/copy_minimatch": "fixtures/copy/*",
    }
  }
}

While getting the tests to pass I noticed that in the compress test I was getting 205 instead of 207 on linux, so I also changed that number so that all the tests would pass for me??

@ctalkington
Copy link
Member

ill have to check into the failing test. see if I notice similar may have to do greater than test, like some of the tar.gz tests since size can vary by OS.

otherwise this should be fine, will review this week for inclusion in next weeks release.

@nnnnathann
Copy link
Contributor Author

Thanks, I'm sure it has something to do with disk format etc between OS, I can investigate it more later tonight

@ctalkington
Copy link
Member

@tkellen have you noticed this lately? I know there were issues with tar/gz but zip hasn't misbehaved on me yet.

@ctalkington
Copy link
Member

going to accept this, as I don't think it hurts anything. will work out compress test issue sometime this week.

ctalkington added a commit that referenced this pull request Aug 16, 2012
Copy task minimatch options
@ctalkington ctalkington merged commit 69af429 into gruntjs:master Aug 16, 2012
@tkellen
Copy link
Member

tkellen commented Aug 16, 2012

Yes, I have noticed that test failing ever since it was created. I left it failing because I intended to change the methodology of the test--I just never got around to it. Now it is your turn to look at it failing, Chris ;)

@ctalkington
Copy link
Member

haha, id really like to find a good way to extract/list contents and compare that. I never liked the size but we needed some sort of test!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants