Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved "Sample Gruntfile" page #178

Merged
merged 1 commit into from
Mar 13, 2016
Merged

Improved "Sample Gruntfile" page #178

merged 1 commit into from
Mar 13, 2016

Conversation

AurelioDeRosa
Copy link
Contributor

Fixes #3

JKVeganAbroad pushed a commit that referenced this pull request Mar 13, 2016
Merge pull request #178 from AurelioDeRosa/sample
53a8ae1 
Improved "Sample Gruntfile" page
@JKVeganAbroad JKVeganAbroad merged commit 53a8ae1 into gruntjs:master Mar 13, 2016
@JKVeganAbroad
Copy link
Contributor

😮!!!!!!!!!!
Amazing! Thanks!

@AurelioDeRosa AurelioDeRosa deleted the sample branch March 13, 2016 00:54
@AurelioDeRosa
Copy link
Contributor Author

Do you have an idea when this and the other changes will be live?

@JKVeganAbroad
Copy link
Contributor

I could do it now I think . . .
I just have to undo a certain change elsewhere in the repository first though, before propagating changes.

@AurelioDeRosa
Copy link
Contributor Author

That sounds cool. I think you meant that you have to fix gruntjs/gruntjs.com#228 first before publishing the changes, right?

@JKVeganAbroad
Copy link
Contributor

Spot on, exactly.
I can't fix it right now, but I can remove the link to the page from the navbar at the top so that the page can't be visited. Like a ghost, it's there, not visible. I'll do that now.

@JKVeganAbroad
Copy link
Contributor

@AurelioDeRosa, with the exception of the new documentation index page, all changes are pushed and live 👍
Thanks again for your hard work with the contributions!

@AurelioDeRosa
Copy link
Contributor Author

Awesome news! Thank you for pushing everything and for the grammar fixes. If you want, next time you can comment on the PR and I can fix them myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AurelioDeRosa @JKVeganAbroad